Skip to content

Fix CallWebhookJob behaviour when throwExceptionOnFailure is true #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

cristian-fleischer
Copy link
Contributor

Currently, the exceptions are not (re)thrown even if the CallWebhookJob::$throwExceptionOnFailure is set to true.
By adding the failed method and re-throwing the exception here if the flag is set to true this issue should be fixed.

Currently, the exceptions are not thrown even if the 'CallWebhookJob::$throwExceptionOnFailure' is set to `true`.
By adding the `failed` method and re-throwing the exception here if the flag is set to true we fix this issue.
@freekmurze freekmurze merged commit 72cd9fd into spatie:main Dec 16, 2024
13 checks passed
@freekmurze
Copy link
Member

Thanks!

@dovid
Copy link

dovid commented Jan 15, 2025

I can't say for sure, but I believe this PR (and its subsequent release) is causing a bunch of 404 exception reports (in my sentry account) that have always failed silently until now. I haven't published the config file fwiw.

@freekmurze
Copy link
Member

@dovid could you pinpoint your issue to a specific change here?

@dovid
Copy link

dovid commented Jan 30, 2025

From what I understand, this PR fixed an issue where exceptions weren’t being thrown, even when throw_exception_on_failure was set to true. As a result, failures were silently ignored, and I had no visibility into them.

After our recent release, which included this update, we suddenly started seeing a flood of exceptions. At first, I was concerned that we had introduced a new issue. However, it turns out this behavior is expected—I just need to set throw_exception_on_failure to false if I don’t want to be notified of these failures.

So, technically, nothing is wrong; it was just a bit jarring to see so many exceptions all at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants