Enhance QueryBuilder with generics support for better type inference #1002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
QueryBuilder
class insrc/QueryBuilder.php
to improve type safety and code clarity by adding template annotations and type hints. The most important changes include adding a template annotation to the class, updating the return type annotations for methods, and ensuring proper type casting.When trying to specify the correct type in the following code:
Static analysis (PHPStan) generates the following error:
It happens because
Illuminate\Database\Eloquent\Builder
is a generic class:but
\Spatie\QueryBuilder\QueryBuilder
that specifies this class as a@mixin
is not generic, so there is no way to specify a concrete type for theTModel
.This PR adds the ability to do this.