Skip to content

feat: websocket cancel flow #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

LordNayan
Copy link
Member

@LordNayan LordNayan commented Mar 18, 2025

Description

Fixes #2699

This PR adds Cancel functionality in websocket in desktop app.

In the below video, I am trying to connect to a websocket that connects after a delay of 3 seconds.

Screen.Recording.2025-03-19.at.3.09.38.AM.mov

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build

Have you tested locally?

  • 👍 yes
  • 🙅 no, because I am lazy

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md

Any Known issue?

Related Story, task & Documents?

@LordNayan LordNayan self-assigned this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Cancel button is required to bypass any ongoing request in Websocket and Socket.IO
1 participant