Skip to content

Commit cbbab48

Browse files
committed
cleanup on distance method logic
1 parent cbdc7c2 commit cbbab48

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/sfTk/sfDevXM125Presence.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,26 +94,26 @@ sfTkError_t sfDevXM125Presence::getPresenceDistanceValuemm(uint32_t &presenceVal
9494

9595
sfTkError_t retVal = getPresenceDetectorErrorStatus(errorStatus);
9696
if (retVal != ksfTkErrOk || errorStatus != 0)
97-
return 1;
97+
return sfTkErrFail;
9898

9999
// Start detector
100100
if (setPresenceCommand(SFE_XM125_PRESENCE_START_DETECTOR) != ksfTkErrOk)
101-
return 2;
101+
return sfTkErrFail;
102102

103103
sftk_delay_ms(100);
104104

105-
// Poll detector status until busy bit is cleared - CHECK ON THIS!
105+
// Poll detector status until busy bit is cleared
106106
if (presenceBusyWait() != ksfTkErrOk)
107-
return 3;
107+
return sfTkErrFail;
108108

109109
// Verify that no error bits are set in the detector status register
110110
retVal = getPresenceDetectorErrorStatus(errorStatus);
111111
if (retVal != ksfTkErrOk || errorStatus != 0)
112-
return 4;
112+
return sfTkErrFail;
113113

114114
// Read from 16-Bit Register to get the presence detection status
115115
if (_theBus->readRegister(SFE_XM125_PRESENCE_RESULT, presenceStatus) != ksfTkErrOk)
116-
return 5;
116+
return sfTkErrFail;
117117

118118
// Presence detected NOW or since last check (sticky)
119119
bool bPresenceDetected = ((presenceStatus & SFE_XM125_PRESENCE_DETECTED_MASK) != 0) ||
@@ -123,6 +123,8 @@ sfTkError_t sfDevXM125Presence::getPresenceDistanceValuemm(uint32_t &presenceVal
123123
if (bPresenceDetected)
124124
return getPresenceDistance(presenceVal);
125125

126+
// If no presence detected, return 0
127+
presenceVal = 0;
126128
return ksfTkErrOk;
127129
}
128130

0 commit comments

Comments
 (0)