Skip to content

Commit cbdc7c2

Browse files
committed
added a start and end value to the detectorStart() method, with default values; This range shouldnt be hard coded
1 parent 4a95723 commit cbdc7c2

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/sfTk/sfDevXM125Presence.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ sfTkError_t sfDevXM125Presence::begin(sfTkII2C *theBus)
3232
return ksfTkErrOk;
3333
}
3434
//-------------------------------------------------------------------------
35-
sfTkError_t sfDevXM125Presence::presenceDetectorStart()
35+
sfTkError_t sfDevXM125Presence::presenceDetectorStart(uint32_t startValue, uint32_t endValue)
3636
{
3737
// *** Presence Sensor Setup ***
3838
uint32_t errorStatus = 0;
@@ -51,13 +51,13 @@ sfTkError_t sfDevXM125Presence::presenceDetectorStart()
5151
return 3;
5252

5353
// Set Presence Start register
54-
if (setPresenceStart(300) != ksfTkErrOk)
54+
if (setPresenceStart(startValue) != ksfTkErrOk)
5555
return 4;
5656

5757
sftk_delay_ms(100); // give time for command to set
5858

5959
// Set End register
60-
if (setPresenceEnd(2500) != ksfTkErrOk)
60+
if (setPresenceEnd(endValue) != ksfTkErrOk)
6161
return 5;
6262

6363
sftk_delay_ms(100); // give time for command to set

src/sfTk/sfDevXM125Presence.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,10 @@ class sfDevXM125Presence : public sfDevXM125Core
246246
sfTkError_t begin(sfTkII2C *theBus = nullptr) override;
247247
/// @brief This function sets all the beginning values for a basic I2C
248248
/// example to be run on the device for presence sensing.
249+
/// @param start Start value for presence sensing in mm - default value is 1000
250+
/// @param end End value for presence sensing in mm - default value is 5000
249251
/// @return ksfTkErrOk on success, or error code (value < -1)
250-
sfTkError_t presenceDetectorStart();
252+
sfTkError_t presenceDetectorStart(uint32_t start = 1000, uint32_t end = 5000);
251253

252254
/// @brief This function returns the presence value of the register
253255
/// with all the checks in place as per the I2C Datasheet.

0 commit comments

Comments
 (0)