fix: auth route conflict

[VishnuSanal]

Description

This PR fixes #982

Summary

This PR does fix authenticated routes with different method but same path causing conflict

PR Checklist

Please ensure that:

• The PR contains a descriptive title
• The PR contains a descriptive summary of the changes
• You build and test your changes before submitting a PR.
• You have added relevant documentation
• You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

• Ensure that you have run the pre-commit hooks on your PR.

[vercel]

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

[VishnuSanal]

todo:

• fix tests
• please comment on the approach @sansyrox

[sansyrox]

Hey @VishnuSanal 👋

Overall , I like the approach ✨

I can do a review on the execution when it is up for review 😄

[codspeed-hq]

CodSpeed Performance Report

Merging #987 will not alter performance

_{Comparing VishnuSanal:fix-auth-route-conflict (cac2435) with main (608fefd)}

Summary

✅ 138 untouched benchmarks

[sansyrox]

Hey @VishnuSanal , can you fetch the latest changes here??

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
robyn	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2025 7:29am

[alissonpelizaro]

Hi all, same issue here.

Any blockers for merging this? Let me know if I can help somehow!

[sansyrox]

Hey @alissonpelizaro 👋

Apologies for the delay in review. I planned to review this over the weekend. If possible, could you do an initial review please?

[sansyrox]

why is this a GET http method? Is a middleware always treated as a get request?

[VishnuSanal]

why is this a GET http method? Is a middleware always treated as a get request?

@sansyrox we are defaulting to GET. previously the value added to routes were just the endpoint, which caused the key conflicts. with this PR, we are making it "<http_method>/". and, I am defaulting all middleware requests to GET. do you think it is a bad idea? I have also tried making it "<middleware_type>/" (code here: https://github.com/VishnuSanal/Robyn/tree/fix-auth-route-conflict-new), but that breaks the middleware tests & I am unable to find a way around. what do you think? which approach to follow?

[VishnuSanal]

why is this a GET http method? Is a middleware always treated as a get request?

update:

yes, here, the req.method() returns GET for all middleware requests. I now realize that this is why the approach on my previous comment didn't work.

[k4976]

why is this a GET http method? Is a middleware always treated as a get request?

@sansyrox
This is just to fulfill the trait definition requirement as defined in mod.rs
if you pass anything here, it will still work
this is middleware router which works differently than base/global router which do lookup based on method + endpoint

[sansyrox]

This PR needs some more work and is up for grabs as @VishnuSanal is unfortunately away for some time.

[k4976]

@VishnuSanal
All looks good to me, except the variable names

Do use correct name which represent their actual property
Like route_type used in python to pass http_method but same parameter name is used as middleware_type in rust which creates little bit confusion,
so please avoid that
so use http_method where it's route_type and use middleware_type where it's of type middleware_type

some variables are used wrongly before also, do check and fix them also
here are some files:
https://github.com/sparckles/Robyn/blob/main/src/routers/middleware_router.rs

[VishnuSanal]

@k4976 thanks for your review. but I have some questions.

route_type used in python to pass http_method but same parameter name is used as middleware_type in rust

use http_method where it's route_type and use middleware_type where it's of type middleware_type

I didn't quite get this 🤔

we are using:

for middleware_type, endpoint, function, route_type in route_middlewares:
        server.add_middleware_route(middleware_type, endpoint, function, route_type)

and the signature for the same on server.rs is:

pub fn add_middleware_route(
        &self,
        middleware_type: &MiddlewareType,
        route: &str,
        function: FunctionInfo,
        http_method: HttpMethod,
    )

here, the middleware_type & http_method are of the same type, right? am I missing something? please CMIIW.

some variables are used wrongly before also, do check and fix them also here are some files: https://github.com/sparckles/Robyn/blob/main/src/routers/middleware_router.rs

I don't think this is the scope of this PR. please create an issue & let's address it in another PR :)

[recurseml]

⚠️ Only 5 files will be analyzed due to processing limits.

[recurseml]

😱 Found 2 issues. Time to roll up your sleeves! 😱