fix: openapi schema generation for non container types #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sansyrox
changed the title
sansyrox
force-pushed
the
fix/openapi-schema-generation
branch
from
e14f272 to
4505168
Compare
sansyrox
force-pushed
the
fix/openapi-schema-generation
branch
from
4505168 to
73448d7
Compare
sansyrox
force-pushed
the
main
branch
5 times, most recently
from
07f28de to
0b766c9
Compare
sansyrox
force-pushed
the
fix/openapi-schema-generation
branch
from
73448d7 to
f413c8c
Compare
for more information, see https://pre-commit.ci
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
| @@ -607,6 +607,9 @@ def ALLOW_CORS(app: Robyn, origins: Union[List[str], str]): | |||
|
|
|||
| @app.before_request() | |||
| def cors_middleware(request): | |||
| if request is None: | |||
There was a problem hiding this comment.
The CORS middleware's handling of None request is incorrect. Middlewares in Robyn should either return the original request object to continue processing or a Response object to short-circuit. Returning None (from line 611) will likely cause undefined behavior or errors in the request processing pipeline. Instead, it should return an appropriate Response object with an error status code if the request is invalid.
React with 👍 to tell me that this comment was useful, or 👎 if not (and I'll stop posting more comments like this in the future)
|
😱 Found 1 issue. Time to roll up your sleeves! 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes openapi schema generation.
Summary
This PR does....
PR Checklist
Please ensure that:
Pre-Commit Instructions: