Skip to content

Add matrix_bridges_msc4190_enabled flag for using msc4190 on supported mautrix bridges. flag for using msc4190 on supported mautrix bridges. #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

onestacked
Copy link
Contributor

@onestacked onestacked commented Apr 16, 2025

Enable the matrix_bridges_msc4190_enabled when MAS is used in combination with matrix_bridges_encryption_enabled.

Enable the msc4190 feature in the mautrix bridgev2 bridges when matrix_bridges_encryption_enabled is enabled.

MSC4190

@onestacked
Copy link
Contributor Author

onestacked commented Apr 16, 2025

I use some bridges that don't support msc4190 yet (mautrix-telegram and mautrix-discord) so I can't use MAS yet and therefore can't really test this, but the config files look correct.

@onestacked
Copy link
Contributor Author

I noticed that matrix_synapse_experimental_features_msc3202_device_masquerading_enabled also needs to be set, not sure what the best way to enable that is.

@spantaleev
Copy link
Owner

I noticed that matrix_synapse_experimental_features_msc3202_device_masquerading_enabled also needs to be set, not sure what the best way to enable that is.

The way you've currently implemented this feature is: if a bunch of prerequsiites are enabled across various cmponents, enable MSC4190 support for bridges that can use it.

So I'd say.. it makes sense to continue this way and to adjust matrix_bridges_msc4190_enabled:

-matrix_bridges_msc4190_enabled: "{{ matrix_authentication_service_enabled && matrix_bridges_encryption_enabled }}"
+matrix_bridges_msc4190_enabled: "{{ matrix_authentication_service_enabled and matrix_bridges_encryption_enabled and matrix_synapse_experimental_features_msc3202_device_masquerading_enabled }}"

@onestacked
Copy link
Contributor Author

onestacked commented Apr 17, 2025

I've now also added mautrix-discord mautrix-telegram, since mautrix/python#175 added support to python bridges and therefore mautrix-discord mautrix-telegram.

@spantaleev spantaleev merged commit 5eb247b into spantaleev:master Apr 17, 2025
3 checks passed
@spantaleev
Copy link
Owner

Thank you! 🙇

@onestacked onestacked deleted the add-msc4190-flag branch April 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants