This repository was archived by the owner on Feb 7, 2025. It is now read-only.
Spectral extraction tests #158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@ibusko Since your notebook was approved in astropy/specreduce#79 and astropy/specreduce#82 on both scientific and technical bases, I'm going to close this pull request. It was said that we don't actually want to merge this notebook here in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to JDAT-1855: "Try already available specreduce functionality on JWST data".
The notebook relies on the kosmos package to build a trace object necessary to run specreduce's boxcar extraction code. It also uses a locally-fixed version of this code, where a bug was removed. Lastly, it has trouble in actually using the Spectrum1D instance created by the extraction code. This object has its wavelength attribute set in pixel units, which causes trouble with code downstream that wants to use it.
The notebook also uses boxcar-extraction code taken from another notebook, adapts and augments it to allow extractions from boths2d and s3d data, and exercises it with JWST simulated data.
Added on 12/08/2021: minimalist boxcar code based on numpy slices (good for rectified 2-D and 3-D data only).