Uniffi dart integration test #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
spacebear21
force-pushed
the
uniffi-dart-tests
branch
from
7528ab0 to
4bf56df
Compare
spacebear21
force-pushed
the
uniffi-dart-tests
branch
from
da80a0f to
c595fe3
Compare
Minimizing the import I was able to get rid of all errors introduced by uniffi-dart and built a successful uniffi binding. These tests are just the barebones of what is built but proves out that we have some functioning bindings when creating a minimal build.
I've included support for including --language args beyond those explicitly supported in uniffi-rs with a match block that passes the chosen language to chose what binding cargo package to use.
The constructors are public as of uniffi-dart db4eed7
the FFI create_session method takes a String, not a URL.
uniffi-dart empty sequence handling was fixed in 8536f95
toString() isn't defined due to Display trait not yet implemented in uniffi-dart, so use asString() instead which is defined.
Pass the "psbt" value as parameter, and return a String instead of a bitcoin.Psbt
Uri.https() expects only the host portion, not a complete URL. Use Uri.parse() instead.
spacebear21
force-pushed
the
uniffi-dart-tests
branch
from
c595fe3 to
0575999
Compare
|
Going to mark this as ready for review so I'm not a blocker @spacebear21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spacebear is taking over this branch to get it across the finish line. We have some remaining thread on the todos for this PR but it is close.