Skip to content

Conversation

@Visne
Copy link
Member

@Visne Visne commented Sep 14, 2025

This PR makes it so that the server list is an actual proper grid, instead of the hacky stuff we've had up until now. This fixes major amounts of lag (when changing filters, or just switching tabs when no filters are applied). It also theoretically makes it possible in the future to add proper sorting (sorting works now :3), and hiding specific columns.

Before (I'm trying to switch tabs and toggle filters as fast as possible):

before.mp4

After (outdated, has column separators and sorting now):

after.mp4

I wish I could provide cleaner separate commits but I've been working on this off and on since February so it got too messy

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PJB3005
Copy link
Member

PJB3005 commented Oct 2, 2025

Aesthetically I definitely prefer having the separators between columns. Also the "go to servers tab" button being full-width is weird.

@Visne
Copy link
Member Author

Visne commented Oct 12, 2025

I've added column separators, and I've fixed the go to servers button. One very minor regression: the go to servers button is now under the scroll container as opposed to inside the scroll container, but because the scroll container is inside the DataGrid it would be quite a pain in the ass to put it inisde (I really wish Avalonia had better documentation for templating). I think it's fine like this.

I've also added column sorting :>

@Visne Visne requested a review from PJB3005 October 12, 2025 02:25
@PJB3005
Copy link
Member

PJB3005 commented Oct 12, 2025

You can't a server info entry after opening it. Also removal of the arrow indicating it's expandable is bad UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants