Skip to content

Better broadphase performance #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+157 −110
Open

Better broadphase performance #6272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a205ed8
Better broadphase parallelism
metalgearsloth Oct 27, 2025
8d30655
Fixes
metalgearsloth Oct 27, 2025
7aa9a8a
Better docs
metalgearsloth Oct 27, 2025
927ab5d
doc
metalgearsloth Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ END TEMPLATE-->
### Other

* Add pure to some SharedTransformSystem methods.
* Significantly optimised collision detection in SharedBroadphaseSystem.

### Internal

Expand Down
3 changes: 2 additions & 1 deletion Robust.Client/Physics/PhysicsSystem.Predict.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ internal void UpdateIsTouching(List<Contact> toUpdate)
if ((contact.Flags & ContactFlags.Filter) != 0x0)
{
if (!ShouldCollide(fixtureA, fixtureB) ||
!ShouldCollide(uidA, uidB, bodyA, bodyB, fixtureA, fixtureB, xformA, xformB))
!ShouldCollideSlow(uidA, uidB, bodyA, bodyB, fixtureA, fixtureB, xformA, xformB) ||
!ShouldCollideJoints(uidA, uidB))
{
contact.IsTouching = false;
continue;
Expand Down
7 changes: 0 additions & 7 deletions Robust.Shared/CVars.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1280,13 +1280,6 @@ protected CVars()
* PHYSICS
*/

/// <summary>
/// How much to expand broadphase checking for. This is useful for cross-grid collisions.
/// Performance impact if additional broadphases are being checked.
/// </summary>
public static readonly CVarDef<float> BroadphaseExpand =
CVarDef.Create("physics.broadphase_expand", 2f, CVar.ARCHIVE | CVar.REPLICATED);

/// <summary>
/// The target minimum ticks per second on the server.
/// This is used for substepping and will help with clipping/physics issues and such.
Expand Down
Loading