Skip to content

Add GetDescendant methods to SharedContainerSystem #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

notquitehadouken
Copy link
Contributor

Title

Specifically, getting every single entity that is contained in a container/entity, including in other containers in those entities

Mostly just for convenience

@notquitehadouken notquitehadouken changed the title Add GetDescendant methods Add GetDescendant methods to ShoredContainerSystem Jul 17, 2025
Copy link
Contributor

@metalgearsloth metalgearsloth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doing a silly amount of allocations.

@notquitehadouken
Copy link
Contributor Author

This is doing a silly amount of allocations.

how silly.......

@pheenty
Copy link

pheenty commented Jul 17, 2025

There is already a method like this but it is private iirc

@pheenty
Copy link

pheenty commented Jul 17, 2025

Nvm it's for ascendant insertion not for descendant enumeration

@notquitehadouken notquitehadouken changed the title Add GetDescendant methods to ShoredContainerSystem Add GetDescendant methods to SharedContainerSystem Jul 17, 2025
Copy link
Member

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these return IEnumerator<T> instead of IEnumerable<T>?

@notquitehadouken
Copy link
Contributor Author

notquitehadouken commented Jul 22, 2025

Why do these return IEnumerator<T> instead of IEnumerable<T>?

¯\_(ツ)_/¯

@PJB3005 PJB3005 added S: Needs Review This PR needs to be reviewed before it can be merged. and removed S: Awaiting Changes labels Jul 22, 2025
@notquitehadouken
Copy link
Contributor Author

...

@notquitehadouken notquitehadouken deleted the 25-07-16-container-nested-enumerator branch July 29, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review This PR needs to be reviewed before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants