Add new event for os window #6049
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beck-thompson
added
T: New Feature
2 tasks
|
So I don't mind having this as a feature (assuming you change the API so the request takes a proper cancellation opportunity), but this PR isn't necessary to implement your content feature. |
PJB3005
added
S: Awaiting Changes
and removed
S: Needs Review
I'm not sure if I should pass through the |
PJB3005
requested changes
Jun 28, 2025
PJB3005
requested changes
Jul 22, 2025
| /// <summary> | ||
| /// Raised when the user clicks the close button on the window. Can be canceled! | ||
| /// </summary> | ||
| public event Action<CancelEventArgs>? RequestClosed; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for space-wizards/space-station-14#36969
Right now, there isn't a way to listen for when the window is requested to close (E.g someone clicks the X button). This means that you have to listen for ALL closes. In the viewport pr, we want to actually close the window when someone presses the x, but we don't want to close it when they simply pop the window back in (that will close the OS window, but not the viewport window)