Traversal + lerping stuff #5929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Undisables cross-parent lerping so grid traversal doesn't lurch. - Fixes some subtly incorrect lerp values if traversal was run in the setter. - Disable traversal when lerping in the rare case it traverses us onto a grid. - Mark the LocalRotation setter as obsolete, was probably just forgotten but this aligns with LocalPosition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ElectroJr
I imagine this may break some stuff but content stuff like container setting or w/e should use the no-lerp version maybe? Or we add a setcoordinates no lerp version helper?
Draft because grid <> grid lerps still lurch