-
Notifications
You must be signed in to change notification settings - Fork 87
MRG: add picklist to sig collect #3805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3805 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 137 137
Lines 22610 22616 +6
Branches 2303 2305 +2
=======================================
+ Hits 19931 19937 +6
Misses 2366 2366
Partials 313 313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@ctb ready for review. If there's an alternate way to do this, just lmk -- I wasn't sure how and wanted the capacity. |
Hmm, this doesn't do exactly what I wanted, which is to select on the existing manifest (keeping the internal_location paths within), rather than create abspath references to the existing manifest. It does work for what I need, though! |
Ah, what I was really looking for was
picklist might still be useful for other uses of |
Here, we add picklist arguments to
sig collect
so we can select on the collected sigs.Is there an alternate way to do this for a standalone manifest?
example usage:
...and checking the resultant standalone manifest: