Linter: create rule to remove empty fragment #1825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karan-palan <karanpalan007@gmail.com>
jviotti
reviewed
Jul 10, 2025
| ModernOfficialDialectWithEmptyFragment() | ||
| : SchemaTransformRule{ | ||
| "modern_official_dialect_with_empty_fragment", | ||
| "The official dialect URI of Draft 2019-09 and newer versions must " |
There was a problem hiding this comment.
Suggested change
| "The official dialect URI of Draft 2019-09 and newer versions must " | |
| "The official dialect URI of 2019-09 and newer versions must " |
We don't say draft anymore for the newer ones!
|
Looks good and looking forward to the tests! |
Signed-off-by: karan-palan <karanpalan007@gmail.com>
…-dialect-empty-fragment
…-dialect-empty-fragment
Signed-off-by: karan-palan <karanpalan007@gmail.com>
Karan-Palan
changed the title
|
@jviotti , I had to make a few change in the official schema resolver to make the tests work. Ptal |
|
Can you send a separate PR with the official resolver changes? Also we should never be modifying the actual schemas in there, i.e. setting the |
jviotti
reviewed
Jul 14, 2025
| R"EOF(@METASCHEMA_JSONSCHEMA_2020_12@)EOF"); | ||
| schema.at("$id").into(sourcemeta::core::JSON{identifier}); |
There was a problem hiding this comment.
We should never mutate the official meta-schemas, as they are supposed to be immutable. What was the intention?
|
Ah, I see the |
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.