Skip to content

style(clang-tidy): fix bugprone-unchecked-optional-access #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 26, 2025
Merged

style(clang-tidy): fix bugprone-unchecked-optional-access #1762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
642c3eb
style(clang-tidy): fix bugprone-unchecked-optional-access
bavulapati Jun 24, 2025
6915b6d
remove irrelevant comments
bavulapati Jun 24, 2025
c40a2c8
Merge branch 'main' into fix-bugprone-unchecked-optional-access
bavulapati Jun 24, 2025
19c685c
address review comments and sign-off
bavulapati Jun 24, 2025
8f429ef
Update src/core/jsonschema/walker.cc
jviotti Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/core/jsonschema/frame.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@ auto find_anchors(const sourcemeta::core::JSON &schema,
const sourcemeta::core::URI identifier(schema.at("$id").to_string());
if (identifier.is_fragment_only()) {
result.insert(
{sourcemeta::core::JSON::String{identifier.fragment().value()},
{sourcemeta::core::JSON::String{
identifier.fragment()
.value()}, // NOLINT(bugprone-unchecked-optional-access):
// Check for optional is happening
// inside is_fragment_only()
AnchorType::Static});
}
}
Expand All @@ -91,7 +95,11 @@ auto find_anchors(const sourcemeta::core::JSON &schema,
const sourcemeta::core::URI identifier(schema.at("id").to_string());
if (identifier.is_fragment_only()) {
result.insert(
{sourcemeta::core::JSON::String{identifier.fragment().value()},
{sourcemeta::core::JSON::String{
identifier.fragment()
.value()}, // NOLINT(bugprone-unchecked-optional-access):
// Check for optional is happening
// inside is_fragment_only()
AnchorType::Static});
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/core/jsonschema/walker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ auto walk(const std::optional<sourcemeta::core::Pointer> &parent,
const auto current_base_dialect{
is_schema_resource
? sourcemeta::core::base_dialect(subschema, resolver, current_dialect)
.value()
.value_or(base_dialect)
: base_dialect};

const auto vocabularies{sourcemeta::core::vocabularies(
Expand Down