Skip to content

style(clang-tidy): fix bugprone-optional-value-conversion #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bavulapati
Copy link
Contributor

Reported with #1754

Reported with sourcemeta#1754

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@bavulapati
Copy link
Contributor Author

@jviotti Can we merge this?

@bavulapati
Copy link
Contributor Author

@jviotti Can we merge this?
This got an approval too.

@jviotti
Copy link
Member

jviotti commented Jun 26, 2025

I missed the notification. Thanks for pinging me again 🙏🏻

@jviotti jviotti merged commit 7945712 into sourcemeta:main Jun 26, 2025
14 checks passed
@bavulapati bavulapati deleted the fix-bugprone-optional-value-conversion branch June 27, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants