chore: move clang-tidy config file to project directory #1702
Conversation
clang-tidy when the config is not explicitly mentioned in the command looks for it in the project directory with the name `.clang-tidy`. And editors like VS Code recognizes the `.clang-tidy` file when code analysis is enabled. This is not a fix for a bug. This is just trying to make clang-tidy config and usage more visible. Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
bavulapati
force-pushed
the
move-clang-tidy-config-to-project-directory
branch
from
d2a48d7 to
587aea5
Compare
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
| @@ -35,13 +35,11 @@ function(sourcemeta_target_clang_tidy) | |||
| file(GLOB_RECURSE SOURCEMETA_TARGET_CLANG_TIDY_FILES | |||
| ${SOURCEMETA_TARGET_CLANG_TIDY_SOURCES}) | |||
|
|
|||
| set(CLANG_TIDY_CONFIG "${CMAKE_CURRENT_FUNCTION_LIST_DIR}/clang-tidy.config") | |||
There was a problem hiding this comment.
Instead of removing this, can you tweak the variable to point at ${PROJECT_DIR}/.clang-tidy (or whatever the right variable name is?)
There was a problem hiding this comment.
If we are moving this file, can we also do the same with the clang-format.config config file in the same directory?
|
Makes sense for this project, but keep in mind that other of my projects pull this repo as a dependency and re-use the same ClangTidy (and ClangFormat) config files. In those child projects, we would have the same problem, as the config files wouldn't be on the root. As an alternative, is there a way we can commit Visual Studio Code config files or something to all repos to always point at the right config file locations, no matter where they are? There might be a way |
clang-tidy when the config is not explicitly mentioned in the command looks for it in the project directory with the name
.clang-tidy. And editors like VS Code recognizes the.clang-tidyfile when code analysis is enabled. This is not a fix for a bug. This is just trying to make clang-tidy config and usage more visible.