chore: move clang-tidy config file to project directory #1702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang-tidy when the config is not explicitly mentioned in the command looks for it in the project directory with the name `.clang-tidy`. And editors like VS Code recognizes the `.clang-tidy` file when code analysis is enabled. This is not a fix for a bug. This is just trying to make clang-tidy config and usage more visible. Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
bavulapati
force-pushed
the
move-clang-tidy-config-to-project-directory
branch
from
d2a48d7 to
587aea5
Compare
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
jviotti
reviewed
May 28, 2025
jviotti
reviewed
May 28, 2025
|
Makes sense for this project, but keep in mind that other of my projects pull this repo as a dependency and re-use the same ClangTidy (and ClangFormat) config files. In those child projects, we would have the same problem, as the config files wouldn't be on the root. As an alternative, is there a way we can commit Visual Studio Code config files or something to all repos to always point at the right config file locations, no matter where they are? There might be a way |
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
|
Not sure why |
|
not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidy when the config is not explicitly mentioned in the command looks for it in the project directory with the name
.clang-tidy. And editors like VS Code recognizes the.clang-tidyfile when code analysis is enabled. This is not a fix for a bug. This is just trying to make clang-tidy config and usage more visible.