Skip to content

style(clang-tidy): fix misc-use-anonymous-namespace #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

style(clang-tidy): fix misc-use-anonymous-namespace #1699

wants to merge 2 commits into from

Conversation

bavulapati
Copy link
Contributor

fixes #1678

@bavulapati
style(clang-tidy): fix misc-use-anonymous-namespace
20e0b0b 
fixes sourcemeta#1678

Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
@jviotti
Copy link
Member

jviotti commented May 26, 2025

Looks generally good, but keep in mind that when you use the anonymous namespace, you should also remove the static qualifiers for each of the helper functions

@bavulapati
remove static specifier
b5c5b63 
Signed-off-by: Balakrishna Avulapati <bavulapati@gmail.com>
@bavulapati
Copy link
Contributor Author

Looks generally good, but keep in mind that when you use the anonymous namespace, you should also remove the static qualifiers for each of the helper functions

Thanks for catching it. It's either static or anonymous namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClangTidy warnings for misc-use-anonymous-namespace
2 participants
@bavulapati @jviotti