Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit b79cf5b

Browse files
authored
remove beta labels for code monitoring Slack notifs & logs (#63480)
These features have passed the steps needed to take them out of beta. They have been feature-complete and in widespread use for more than a year with no outstanding issues, and they work well. - https://linear.app/sourcegraph/project/slack-notifications-ga-code-monitoring-7dbb9fa13f62 - https://linear.app/sourcegraph/issue/SRCH-533/remove-beta-label-from-code-monitor-logs-tab Closes https://linear.app/sourcegraph/issue/SRCH-533/remove-beta-label-from-code-monitor-logs-tab ## Test plan Create a new code monitor with a Slack notif. Ensure it works e2e by pushing a commit that matches and watching it show up in Slack (https://sourcegraph.slack.com/archives/C68386Z5Z/p1719357942294309). ## Changelog - Code monitoring Slack notifications, previously in beta, are now GA. This feature lets you post matching code changes to a Slack channel. - Code monitoring logs, previously in beta, are now GA. This feature lets you see the status of and activity related to code monitors to troubleshoot issues with finding results and performing configured actions.
1 parent f4bf9a6 commit b79cf5b

File tree

3 files changed

+8
-37
lines changed

3 files changed

+8
-37
lines changed

client/web/src/enterprise/code-monitoring/CodeMonitoringPage.tsx

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import React, { useMemo, useEffect, useState, useLayoutEffect, useCallback } from 'react'
1+
import React, { useCallback, useEffect, useLayoutEffect, useMemo, useState } from 'react'
22

33
import { mdiPlus } from '@mdi/js'
44
import classNames from 'classnames'
5-
import { type Location, useNavigate, useLocation, type NavigateFunction } from 'react-router-dom'
5+
import { useLocation, useNavigate, type Location, type NavigateFunction } from 'react-router-dom'
66
import { of } from 'rxjs'
77
import { catchError, map } from 'rxjs/operators'
88

@@ -11,24 +11,15 @@ import type { Settings } from '@sourcegraph/shared/src/schema/settings.schema'
1111
import type { SettingsCascadeProps } from '@sourcegraph/shared/src/settings/settings'
1212
import type { TelemetryV2Props } from '@sourcegraph/shared/src/telemetry'
1313
import { EVENT_LOGGER } from '@sourcegraph/shared/src/telemetry/web/eventLogger'
14-
import {
15-
PageHeader,
16-
LoadingSpinner,
17-
useObservable,
18-
Button,
19-
Link,
20-
ProductStatusBadge,
21-
Icon,
22-
ButtonLink,
23-
} from '@sourcegraph/wildcard'
14+
import { Button, ButtonLink, Icon, Link, LoadingSpinner, PageHeader, useObservable } from '@sourcegraph/wildcard'
2415

2516
import type { AuthenticatedUser } from '../../auth'
2617
import { CodeMonitoringLogo } from '../../code-monitoring/CodeMonitoringLogo'
2718
import { PageTitle } from '../../components/PageTitle'
2819

2920
import {
30-
fetchUserCodeMonitors as _fetchUserCodeMonitors,
3121
fetchCodeMonitors as _fetchCodeMonitors,
22+
fetchUserCodeMonitors as _fetchUserCodeMonitors,
3223
toggleCodeMonitorEnabled as _toggleCodeMonitorEnabled,
3324
} from './backend'
3425
import { CodeMonitoringGettingStarted } from './CodeMonitoringGettingStarted'
@@ -205,10 +196,7 @@ export const CodeMonitoringPage: React.FunctionComponent<React.PropsWithChildren
205196
}}
206197
className={classNames('nav-link', isActive && 'active')}
207198
>
208-
<span>
209-
{title}
210-
{tab === 'logs' && <ProductStatusBadge status="beta" className="ml-2" />}
211-
</span>
199+
<span>{title}</span>
212200
</ButtonLink>
213201
</div>
214202
))}

client/web/src/enterprise/code-monitoring/components/__snapshots__/FormActionArea.test.tsx.snap

Lines changed: 1 addition & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/web/src/enterprise/code-monitoring/components/actions/SlackWebhookAction.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React, { useCallback, useMemo, useState } from 'react'
33
import { gql, useMutation } from '@apollo/client'
44
import { noop } from 'lodash'
55

6-
import { Alert, Input, Link, ProductStatusBadge, Label } from '@sourcegraph/wildcard'
6+
import { Alert, Input, Label, Link } from '@sourcegraph/wildcard'
77

88
import type { SendTestSlackWebhookResult, SendTestSlackWebhookVariables } from '../../../../graphql-operations'
99
import type { ActionProps } from '../FormActionArea'
@@ -101,11 +101,7 @@ export const SlackWebhookAction: React.FunctionComponent<React.PropsWithChildren
101101

102102
return (
103103
<ActionEditor
104-
title={
105-
<div>
106-
Send Slack message to channel <ProductStatusBadge className="ml-1 mb-1" status="beta" />{' '}
107-
</div>
108-
}
104+
title={<div>Send Slack message to channel</div>}
109105
subtitle="Post to a specified Slack channel. Requires webhook configuration."
110106
idName="slack-webhook"
111107
disabled={disabled}

0 commit comments

Comments
 (0)