Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Commit f4bf9a6

Browse files
authored
omit go:embed of big assets from sg start single-program-experimental-blame-sqs (#63477)
This cuts building `./cmd/sourcegraph` from ~60s to ~6s when using `sg start single-program-experimental-blame-sqs` (which is dev only and never needs bundled assets). ## Test plan n/a, dev experimental only
1 parent 37b6ded commit f4bf9a6

File tree

4 files changed

+3
-2
lines changed

4 files changed

+3
-2
lines changed

cmd/frontend/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ go_library(
1010
importpath = "github.com/sourcegraph/sourcegraph/cmd/frontend",
1111
visibility = ["//visibility:private"],
1212
deps = [
13+
"//client/web/dist",
1314
"//cmd/frontend/shared",
1415
"//internal/sanitycheck",
1516
],

cmd/frontend/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ package main
44
import (
55
"github.com/sourcegraph/sourcegraph/cmd/frontend/shared"
66
"github.com/sourcegraph/sourcegraph/internal/sanitycheck"
7+
8+
_ "github.com/sourcegraph/sourcegraph/client/web/dist" // use assets
79
)
810

911
func main() {

cmd/frontend/shared/BUILD.bazel

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ go_library(
1010
importpath = "github.com/sourcegraph/sourcegraph/cmd/frontend/shared",
1111
visibility = ["//visibility:public"],
1212
deps = [
13-
"//client/web/dist",
1413
"//cmd/frontend/enterprise",
1514
"//cmd/frontend/internal/auth",
1615
"//cmd/frontend/internal/authz",

cmd/frontend/shared/service.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import (
1818
"github.com/sourcegraph/sourcegraph/internal/tracer"
1919
"github.com/sourcegraph/sourcegraph/ui/assets"
2020

21-
_ "github.com/sourcegraph/sourcegraph/client/web/dist" // use assets
2221
_ "github.com/sourcegraph/sourcegraph/cmd/frontend/internal/registry"
2322
_ "github.com/sourcegraph/sourcegraph/cmd/frontend/registry/api"
2423
)

0 commit comments

Comments
 (0)