remove extraneous Cody onboarding steps (#63373)

- Remove the "personal or work" step
- Remove the "do you want us to call you?" step
- Cleaner design of the Cody dashboard
- Improve some wording
- Remove CodySurveyToast (unused) and user.CompletedPostSignup. These
have not been used in many months. On Amplitude, the relevant events
have no data.

Fix
https://linear.app/sourcegraph/issue/PRIME-375/remove-personal-or-work-survey-signup-step

<img width="2032" alt="image"
src="https://github.com/sourcegraph/sourcegraph/assets/1976/ef100e60-71b5-479b-ac63-2450cdad0220">


## Test plan

n/a

Author: sqs

client/shared/src/auth.ts

@@ -42,7 +42,6 @@ export const currentAuthStateQuery = gql`
             viewerCanAdminister
             tosAccepted
             hasVerifiedEmail
-            completedPostSignup
             emails {
                 email
                 verified

client/shared/src/settings/temporary/TemporarySettings.ts

@@ -93,7 +93,6 @@ export interface TemporarySettingsSchema {
     'admin.hasCompletedLicenseCheck': boolean
     'simple.search.toggle': boolean
     'cody.onboarding.completed': boolean
-    'cody.onboarding.step': number
 
     /** OpenCodeGraph */
     'openCodeGraph.annotations.visible': boolean
@@ -161,7 +160,6 @@ const TEMPORARY_SETTINGS: Record<keyof TemporarySettings, null> = {
     'admin.hasCompletedLicenseCheck': null,
     'simple.search.toggle': null,
     'cody.onboarding.completed': null,
-    'cody.onboarding.step': null,
     'openCodeGraph.annotations.visible': null,
 }
 

client/shared/src/telemetry/event-names.ts

@@ -15,7 +15,6 @@ export const enum EventName {
     CODY_CHAT_SCOPE_INFERRED_REPO_DISABLED = 'web:codyChat:inferredRepoDisabled',
     CODY_CHAT_SCOPE_INFERRED_FILE_ENABLED = 'web:codyChat:inferredFileEnabled',
     CODY_CHAT_SCOPE_INFERRED_FILE_DISABLED = 'web:codyChat:inferredFileDisabled',
-    VIEW_GET_CODY = 'GetCody',
 
     CODY_EDITOR_WIDGET_VIEWED = 'web:codyEditorWidget:viewed',
     CODY_SIDEBAR_CHAT_OPENED = 'web:codySidebar:chatOpened',

client/shared/src/testing/integration/graphQlResults.ts

@@ -21,7 +21,6 @@ export const currentUserMock = {
     emails: [{ email: 'felix@sourcegraph.com', isPrimary: true, verified: true }],
     latestSettings: null,
     hasVerifiedEmail: true,
-    completedPostSignup: true,
     permissions: {
         __typename: 'PermissionConnection',
         nodes: [

client/web-sveltekit/src/params/reporev.ts

@@ -33,12 +33,9 @@ const topLevelPaths = [
     'search/cody',
     'app',
     'cody',
-    'get-cody',
-    'post-sign-up',
     'unlock-account',
     'password-reset',
     'survey',
-    'welcome',
     'embed',
     'users',
     'user',

client/web/BUILD.bazel

@@ -160,7 +160,6 @@ ts_project(
         "src/auth/AuthPageWrapper.tsx",
         "src/auth/CloudSignUpPage.tsx",
         "src/auth/OrDivider.tsx",
-        "src/auth/PostSignUpPage.tsx",
         "src/auth/RequestAccessPage.tsx",
         "src/auth/ResetPasswordPage.tsx",
         "src/auth/SignInPage.tsx",
@@ -228,7 +227,6 @@ ts_project(
         "src/cody/components/ScopeSelector/index.tsx",
         "src/cody/components/ScopeSelector/useRepoSuggestions.ts",
         "src/cody/dashboard/CodyDashboardPage.tsx",
-        "src/cody/editorGroups.ts",
         "src/cody/invites/AcceptInviteBanner.tsx",
         "src/cody/invites/InviteUsers.tsx",
         "src/cody/invites/useInviteParams.ts",
@@ -263,14 +261,6 @@ ts_project(
         "src/cody/management/subscription/manage/utils.ts",
         "src/cody/management/subscription/new/CodyProCheckoutForm.tsx",
         "src/cody/management/subscription/new/NewCodyProSubscriptionPage.tsx",
-        "src/cody/onboarding/CodyOnboarding.tsx",
-        "src/cody/onboarding/EditorStep.tsx",
-        "src/cody/onboarding/PurposeStep.tsx",
-        "src/cody/onboarding/WelcomeStep.tsx",
-        "src/cody/onboarding/instructions/CodyFeatures.tsx",
-        "src/cody/onboarding/instructions/JetBrains.tsx",
-        "src/cody/onboarding/instructions/NeoVim.tsx",
-        "src/cody/onboarding/instructions/VsCode.tsx",
         "src/cody/sidebar/CodySidebar.tsx",
         "src/cody/sidebar/Provider.tsx",
         "src/cody/sidebar/index.tsx",
@@ -1103,7 +1093,6 @@ ts_project(
         "src/fuzzyFinder/SearchValue.ts",
         "src/fuzzyFinder/SearchValueRankingCache.ts",
         "src/fuzzyFinder/WordSensitiveFuzzySearch.ts",
-        "src/get-cody/GetCodyPage.tsx",
         "src/global/GlobalAlert.tsx",
         "src/global/GlobalAlerts.tsx",
         "src/global/Notices.tsx",
@@ -1126,7 +1115,6 @@ ts_project(
         "src/marketing/components/TweetFeedback.tsx",
         "src/marketing/page/SurveyForm.tsx",
         "src/marketing/page/SurveyPage.tsx",
-        "src/marketing/toast/CodySurveyToast.tsx",
         "src/marketing/toast/SurveySuccessToast.tsx",
         "src/marketing/toast/SurveyToastContent.tsx",
         "src/marketing/toast/SurveyToastTrigger.tsx",

client/web/src/LegacyLayout.tsx

@@ -98,15 +98,9 @@ export const LegacyLayout: FC<LegacyLayoutProps> = props => {
     const isSiteInit = location.pathname === PageRoutes.SiteAdminInit.toString()
     const isSignInOrUp =
         routeMatch &&
-        [
-            PageRoutes.SignIn,
-            PageRoutes.SignUp,
-            PageRoutes.PasswordReset,
-            PageRoutes.Welcome,
-            PageRoutes.RequestAccess,
-        ].includes(routeMatch as PageRoutes)
-    const isGetCodyPage = location.pathname === PageRoutes.GetCody.toString()
-    const isPostSignUpPage = location.pathname === PageRoutes.PostSignUp.toString()
+        [PageRoutes.SignIn, PageRoutes.SignUp, PageRoutes.PasswordReset, PageRoutes.RequestAccess].includes(
+            routeMatch as PageRoutes
+        )
 
     const [newSearchNavigation] = useNewSearchNavigation()
     const [enableContrastCompliantSyntaxHighlighting] = useFeatureFlag('contrast-compliant-syntax-highlighting')
@@ -228,7 +222,7 @@ export const LegacyLayout: FC<LegacyLayoutProps> = props => {
                     telemetryRecorder={props.platformContext.telemetryRecorder}
                 />
             )}
-            {!isSiteInit && !isSignInOrUp && !isGetCodyPage && !isPostSignUpPage && (
+            {!isSiteInit && !isSignInOrUp && (
                 <>
                     {newSearchNavigation ? (
                         <NewGlobalNavigationBar

client/web/src/auth/PostSignUpPage.tsx

@@ -11,13 +11,12 @@ import { Container, Link, Text } from '@sourcegraph/wildcard'
 import type { AuthenticatedUser } from '../auth'
 import { PageTitle } from '../components/PageTitle'
 import type { SourcegraphContext } from '../jscontext'
-import { PageRoutes } from '../routes.constants'
 import { EventName } from '../util/constants'
 
 import { AuthPageWrapper } from './AuthPageWrapper'
 import { CloudSignUpPage, ShowEmailFormQueryParameter } from './CloudSignUpPage'
 import { getReturnTo } from './SignInSignUpCommon'
-import { type SignUpArguments, SignUpForm } from './SignUpForm'
+import { SignUpForm, type SignUpArguments } from './SignUpForm'
 import { VsCodeSignUpPage } from './VsCodeSignUpPage'
 
 import styles from './SignUpPage.module.scss'
@@ -92,8 +91,7 @@ export const SignUpPage: React.FunctionComponent<React.PropsWithChildren<SignUpP
             const v2Source = query.get('editor') === 'vscode' ? 0 : 1
             telemetryRecorder.recordEvent('auth.signUp', 'complete', { metadata: { source: v2Source } })
 
-            // Redirects to the /post-sign-up after successful signup on sourcegraphDotCom.
-            window.location.replace(context.sourcegraphDotComMode ? PageRoutes.PostSignUp : returnTo)
+            window.location.replace(returnTo)
 
             return Promise.resolve()
         })