Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

chore(gha): comment on PR about reviews #8942

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

jhchabran
Copy link
Contributor

@jhchabran jhchabran commented May 14, 2024

Copy link

netlify bot commented May 14, 2024

Deploy Preview for sourcegraph-handbook ready!

Name Link
🔨 Latest commit f793ebc
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph-handbook/deploys/664350a428a32d0008f0cbae
😎 Deploy Preview https://deploy-preview-8942--sourcegraph-handbook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

⚠️ As we're migrating to Notion, we want to make sure that changes to the handbook are only absolutely necessary. To ensure it'is the case, it's now mandatory to get an approving review to merge a pull request.

@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

⚠️ As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

⚠️ As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

⚠️ As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

@github-actions github-actions bot requested a review from madisongclark May 14, 2024 10:32
@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

⚠️ As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

Sourcegraphers: Reach out to #wg-notion if you have any question.

@jhchabran jhchabran force-pushed the jh/notion/warn-on-pr branch from 8f98781 to b822d2a Compare May 14, 2024 10:34
@jhchabran jhchabran requested a review from a team May 14, 2024 10:37
@burmudar
Copy link
Contributor

burmudar commented May 14, 2024

@jhchabran what do you think of... see https://github.com/orgs/community/discussions/16925

Warning

As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

Sourcegraphers: Reach out to #wg-notion if you have any question.

@jhchabran jhchabran closed this May 14, 2024
@jhchabran jhchabran reopened this May 14, 2024
Copy link

Warning

As we're migrating to Notion, we want to make sure that changes to the handbook are absolutely necessary. To ensure it is the case, it's now mandatory to get an approving review to merge a pull request.

Examples

  • Setting up a redirection to a Notion page: PR will be approved.
  • Correcting an important mistake on a page that doesn't have an equivalent yet: PR will be approved.
  • Updating content that isn't mission critical: PR will be rejected.

Sourcegraphers: Reach out to #wg-notion if you have any question.

@jhchabran jhchabran requested a review from burmudar May 14, 2024 11:54
@jhchabran jhchabran merged commit d0f47e7 into main May 14, 2024
@jhchabran jhchabran deleted the jh/notion/warn-on-pr branch May 14, 2024 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants