Skip to content

google: upgrade provider and modules to support v6.x #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 1, 2025
Merged

google: upgrade provider and modules to support v6.x #34

merged 6 commits into from
May 1, 2025

Conversation

devdinu
Copy link
Contributor

@devdinu devdinu commented Apr 25, 2025 •
edited
Loading

  • Upgraded google tf provider to 6.32.0
  • Upgraded budget module to 18.0.0
  • Upgraded gkeprivate to 36.3.0
  • Upgraded google_beta provider to 6.32.0

closes CLO-1506

@devdinu devdinu requested a review from a team April 25, 2025 21:15
@devdinu devdinu self-assigned this Apr 25, 2025
@devdinu devdinu marked this pull request as draft April 25, 2025 21:15
@devdinu devdinu force-pushed the enable_gkeprivate_dns branch 2 times, most recently from 8fa3d12 to 50aaaa2 Compare April 29, 2025 02:04
@devdinu devdinu force-pushed the enable_gkeprivate_dns branch from 50aaaa2 to a125af7 Compare April 29, 2025 02:24
@devdinu
Upgrade google provider to 6.32.0
544c431 
we need to upgrade google provider to enable control plane dns in gkeprivate.
@michaellzc
Copy link
Member

cdktf.json should have been removed (sorry my bad for not cleaning up) as we use our own tooling to generate the go binding instead of the upstream cdktf-cli.

see https://github.com/sourcegraph/cdktf-provider-gen?tab=readme-ov-file#usage

@devdinu devdinu force-pushed the enable_gkeprivate_dns branch 2 times, most recently from 19d85cc to 55752a8 Compare April 29, 2025 23:49
@devdinu
update google provider version to 6.32.0 and budget to 18.0.0
9e4ed85 
upgrade of budget module is required to upgrade google provider
without the version conflict.
@devdinu devdinu force-pushed the enable_gkeprivate_dns branch from 55752a8 to 9e4ed85 Compare April 29, 2025 23:51
@devdinu devdinu marked this pull request as ready for review April 30, 2025 00:10
@devdinu devdinu force-pushed the enable_gkeprivate_dns branch from 48331be to bc721c6 Compare April 30, 2025 00:17
@michaellzc
Copy link
Member

michaellzc commented Apr 30, 2025 •
edited
Loading

  • in the future, you can split PR like this into two commits like postgresql: upgrade to v1.25.0 #35, so the one that bump the *.yml can be reviewed individually. github UI just gives up with massive diff like this
  • you also want to bump google-beta as well as they should be kept in sync

@michaellzc michaellzc changed the title gkeprivate: upgrade version to v31.1.0 google: upgrade provider to v6.x Apr 30, 2025
@michaellzc michaellzc changed the title google: upgrade provider to v6.x google: upgrade provider and modules to support v6.x Apr 30, 2025
@devdinu devdinu merged commit 9e4b603 into main May 1, 2025
@devdinu devdinu deleted the enable_gkeprivate_dns branch May 1, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaellzc michaellzc michaellzc approved these changes

@filiphaftek filiphaftek Awaiting requested review from filiphaftek

Assignees

@devdinu devdinu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devdinu @michaellzc