feat(autoedit): Use unified diff image for debug panel, improve hot streak display #7825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
force-pushed
the
tr/use-unified-image
branch
from
eeb819b to
a0e4e7c
Compare
umpox
changed the title
umpox
commented
Apr 30, 2025
| } | ||
|
|
||
| const { diff } = makeVisualDiff(decorationInfo, 'unified', state.document) | ||
| return generateSuggestionAsImage({ |
There was a problem hiding this comment.
Ah I didn't realise we called calculateSideBySideDiff every time the item transitions to a new phase :/ might omit this as wary of generating lots of images unncessarily
|
This PR is marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed automatically in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image:
Switches from the custom diff implementation to just showing a unified diff image in the debug panel.
Hot streak:
Test plan
Manually tested on different examples in debug panel