Skip to content

Feat: reset button #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Feat: reset button #40

wants to merge 2 commits into from

Conversation

shirsho-12
Copy link
Contributor

@shirsho-12 shirsho-12 commented Jun 26, 2025

Fix reset button functionality, saves local editor as well. Closes #34

@shirsho-12 shirsho-12 marked this pull request as draft June 26, 2025 16:03
@shirsho-12 shirsho-12 changed the title Reset button Feat: reset button Jun 26, 2025
@shirsho-12 shirsho-12 marked this pull request as ready for review June 26, 2025 16:15
@shirsho-12
Copy link
Contributor Author

Review and merge after #19

@shirsho-12
Copy link
Contributor Author

Clicking reset currently does not trigger save on the editor due to #39.

// sendToFrontendWrapped(message);
}

async reset(prepend: string, initialCode: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On resets, the prepend is lost because prepend is always an empty string.

@heyzec
Copy link
Collaborator

heyzec commented Jun 29, 2025

Apologies, let me close this PR and integrate your reset changes into a new one where I'll refactor editor.ts.

@heyzec heyzec closed this Jun 29, 2025
@heyzec heyzec mentioned this pull request Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assessments: Reset button not working
2 participants