Skip to content

feat: better association of .js to Source #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

feat: better association of .js to Source #25

merged 3 commits into from
Jun 24, 2025

Conversation

heyzec
Copy link
Collaborator

@heyzec heyzec commented Jun 21, 2025

Typically, VS Code knows which LSP server to launch as the filetype is based on the extension of the file. We previously discussed and agreed that we do not want to create a custom file extension, e.g. .sjs, to represent Source.

To workaround this limitation, this PR uses to approaches:

  1. Extension modifies workspace-specific settings.json for Source Academy folder, such that .js files here will now be associated with Source.
  2. Regardless of which workspace the user's VS Code is in, editor buffers created by the extension will be programmatically set to Source.

@heyzec heyzec requested a review from mug1wara26 June 21, 2025 15:41
@heyzec heyzec force-pushed the associate-source branch from 9792cd5 to f6296f2 Compare June 21, 2025 15:44
@heyzec heyzec force-pushed the associate-source branch from f6296f2 to 602a31f Compare June 24, 2025 13:06
@heyzec
Copy link
Collaborator Author

heyzec commented Jun 24, 2025

Thanks @mug1wara26 for testing!

@heyzec heyzec merged commit e1c746e into main Jun 24, 2025
2 checks passed
@heyzec heyzec deleted the associate-source branch June 24, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant