Skip to content

Overwrite fix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 25, 2025
Merged

Overwrite fix #21

merged 10 commits into from
Jun 25, 2025

Conversation

mug1wara26
Copy link
Collaborator

Fix for #9

@mug1wara26 mug1wara26 requested a review from heyzec June 17, 2025 04:43
@mug1wara26
Copy link
Collaborator Author

mug1wara26 commented Jun 17, 2025 •
edited
Loading

oops i accidentally reverted to an older lsp version it seems
edit: wait nvm i re-reverted that lol

heyzec
heyzec reviewed Jun 19, 2025
View reviewed changes
@heyzec
Copy link
Collaborator

heyzec commented Jun 19, 2025

(For future reference)
image

The notification will disappear after a while. Can we make it stay there until dismissed?

@mug1wara26 @heyzec
Update src/utils/editor.ts
0dd4cfb 
Co-authored-by: heyzec <61238538+heyzec@users.noreply.github.com>
@mug1wara26
Copy link
Collaborator Author

(For future reference) image

The notification will disappear after a while. Can we make it stay there until dismissed?

From the vscode docs, it seems like there is an option to make it a modal dialog, which might make it persistent? I will test it
image

@mug1wara26
Copy link
Collaborator Author

image
Using modal does make it persistent until the user picks one but it also puts a cancel option in between server and local

@mug1wara26
Copy link
Collaborator Author

image
We could reword the dialog box to this instead

@heyzec
Copy link
Collaborator

heyzec commented Jun 24, 2025

This modal looks good. A small one, can we make it send one Text message right after the user cancels? Otherwise, the frontend still is using the old version and we can see bug on running the code.

@heyzec heyzec self-requested a review June 25, 2025 18:53
heyzec
heyzec approved these changes Jun 25, 2025
View reviewed changes
Copy link
Collaborator

@heyzec heyzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@heyzec heyzec merged commit 1194a9a into main Jun 25, 2025
2 checks passed
@heyzec heyzec deleted the overwrite-fix branch June 25, 2025 18:54
@heyzec heyzec mentioned this pull request Jun 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyzec heyzec heyzec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mug1wara26 @heyzec