Skip to content

Fixes #999 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

PossibilityZero
Copy link
Contributor

Fixes issues described in #999:

  1. Simple syntax errors with unmatched parentheses
  2. A problem with the built in member function that only happens with the Source §2 interpreter
  3. A logic error in the current solution, where the selectors return single-item lists (eg. list("x")) that deriv can't handle.

Also fixes an typo in the problem description (unnecessary parentheses for number literal).

- Correct syntax errors
- Fix usage of features not defined for the Source interpreter of
  Chapter 2
- Fix logic error handing single-item lists to deriv function
@RichDom2185 RichDom2185 self-requested a review May 27, 2024 00:13
@RichDom2185 RichDom2185 requested a review from martin-henz June 24, 2024 10:36
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work @PossibilityZero

@martin-henz martin-henz merged commit e1534f6 into source-academy:master Jun 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants