-
Notifications
You must be signed in to change notification settings - Fork 108
Remove Non-Det Interpreter #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 13576250348Details
💛 - Coveralls |
Let me know when it's ready for review, thanks! |
It is ready for review I guess, if we don't mind the coverage drop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor nits :)
…nto remove-non-det
…nto remove-non-det
…nto remove-non-det
Hi, please run the command |
@s-kybound I've done as requested, but I've now got a bunch of failing tests that I'm not sure what to do about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Instead of doing the big jump and removing everything at once, I think it might be better if I broke down #1707 into several different PRs.
Will resolve:
src/interpreter/interpreter-non-det.ts
(currently not working anyway) #1695