Skip to content

Streamline CSE machine #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

s-kybound
Copy link
Member

@s-kybound s-kybound commented Jul 17, 2024

Description

Streamlines the logic behind continuations, removing GENERATE_CONT and RESUME_CONT instructions. Instead, continuations are now generated immediately upon calling call/cc, and continuations are applied immediately upon being called, without need for other instructions. All logic has been moved to CALL.

Also changes the continuation implementation to be less hacky. Instead of appending continuation data (C, S and E) to a function, continuations now have their own class representation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jul 17, 2024

Pull Request Test Coverage Report for Build 9986259603

Details

  • 36 of 36 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 81.524%

Totals Coverage Status
Change from base Build 9576265212: -0.008%
Covered Lines: 10921
Relevant Lines: 13029

💛 - Coveralls

@martin-henz martin-henz self-requested a review July 18, 2024 08:38
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Things become clearer and simpler.

@martin-henz martin-henz merged commit e4e4631 into source-academy:master Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants