-
Notifications
You must be signed in to change notification settings - Fork 172
feat: various features for VS Code #3146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
by not sending Text messages from frontend to VSC
- New MCQQuestion message type
This reverts commit 18c4597.
Remove the question description from the McqQuestion payload as it is not used.
This reverts commit 230e689.
Unfortunately, the changes with deps on master has made the tests fail, this may take a while |
This reverts commit f204b4a.
@@ -60,6 +61,23 @@ const Assessment: React.FC = () => { | |||
const { courseId, role, assessmentOverviews: assessmentOverviewsUnfiltered } = useSession(); | |||
const dispatch = useDispatch(); | |||
|
|||
useEffect(() => { | |||
if (assessmentOverviewsUnfiltered && courseId) { | |||
sendToWebview( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this why we are sending everything (including upcoming ones)? Looks good for now but can always make this minor change in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
This PR is needed for the following:
Features:
Type of change
How to test
Checklist