integrate conductor into frontend #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
publicFlags.ts contains a list of "public" flags to be displayed in some sort of UI later set flag `conductor.enable` to true to use conductor execution
this enables use of prepack hooks to automatically build raw deps on install
resolved yarn lockfile merge conflict by regenerating based on local copy
7 tasks
|
#3091 will fix the CI issues (hopefully) |
RichDom2185
requested changes
Feb 5, 2025
Pull Request Test Coverage Report for Build 13384070990Details
💛 - Coveralls |
this should fix webpack complaining about the dynamic import
also make feature flags a full class, and add evaluator url flag
…tFeature -> selectFeatureSaga this makes it clear that selectFeature is intended to be called from redux-saga
…t should be a no-op also change featureSelector to take a flag instead of just its name
|
hold on, there's a small bug with the repl eval button, will fix in a bit |
introduce missing conductor feature flag check in eval button logic
|
eval bug is fixed and there should be no change in behaviour when conductor.enable is off there's a ui bug in conductor mode where running something in the repl while the runner isn't running will make it look like the runner is running, even though it will not be started (this is due to isRunning being set to true in replReducer/evalRepl - i cannot check the feature flag in this reducer to switch behaviour off) |
martin-henz
approved these changes
Feb 18, 2025
RichDom2185
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
integrated conductor system for a standard language implementation interface
implemented basic feature flag system
new conductor execution system is hidden behind the
conductor.enableflag.also upgraded yarn (4.6.0) to enable prepack script to be run automatically when installing raw dependencies
Type of change
How to test
old behaviour was left untouched; no changes to tests.