Skip to content

Bump Prettier and ESLint, improve code quality and typing #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Conversation

RichDom2185
Copy link
Member

Description

Also removed outdated types dependencies.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 requested a review from sayomaki August 15, 2024 15:51
@RichDom2185 RichDom2185 self-assigned this Aug 15, 2024
@RichDom2185 RichDom2185 enabled auto-merge (squash) August 15, 2024 15:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10406581400

Details

  • 9 of 74 (12.16%) changed or added relevant lines in 21 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 31.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/editor/Editor.tsx 0 1 0.0%
src/commons/editor/UseHighlighting.tsx 1 2 50.0%
src/commons/sagas/AchievementSaga.ts 0 1 0.0%
src/features/stories/StoriesActions.ts 0 1 0.0%
src/features/cseMachine/CseMachineLayout.tsx 0 2 0.0%
src/features/cseMachine/components/ControlItemComponent.tsx 0 2 0.0%
src/features/cseMachine/components/StashItemComponent.tsx 0 2 0.0%
src/features/cseMachine/java/components/Environment.tsx 0 2 0.0%
src/commons/achievement/utils/InsertFakeAchievements.ts 0 3 0.0%
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/achievement/subcomponents/AchievementDashboard.tsx 1 0.0%
src/features/cseMachine/java/components/StashItem.tsx 1 0.0%
Totals Coverage Status
Change from base Build 10405999458: -0.005%
Covered Lines: 4826
Relevant Lines: 14402

💛 - Coveralls

Copy link
Contributor

@sayomaki sayomaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the changes, and everything seems great!

@RichDom2185 RichDom2185 merged commit 145ccd9 into master Aug 16, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the bump-lint branch August 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants