Skip to content

Add LLM improvements #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 11, 2024
Merged

Add LLM improvements #3010

merged 14 commits into from
Aug 11, 2024

Conversation

RichDom2185
Copy link
Member

Description

  • Move summary notes to BE to prevent bypassing prompt
  • Update request format

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Aug 4, 2024
@yiwen101 yiwen101 marked this pull request as ready for review August 10, 2024 17:45
@coveralls
Copy link

coveralls commented Aug 10, 2024

Pull Request Test Coverage Report for Build 10337779335

Details

  • 4 of 35 (11.43%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 31.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/sicp/chatCompletion/sicpNotes.ts 0 1 0.0%
src/features/sicp/chatCompletion/api.ts 0 9 0.0%
src/pages/sicp/subcomponents/chatbot/ChatBox.tsx 4 25 16.0%
Files with Coverage Reduction New Missed Lines %
src/pages/sicp/subcomponents/chatbot/ChatBox.tsx 1 7.46%
src/features/sicp/chatCompletion/chatCompletion.ts 3 0.0%
Totals Coverage Status
Change from base Build 10266162392: -0.2%
Covered Lines: 4819
Relevant Lines: 14583

💛 - Coveralls

Copy link
Contributor

@yiwen101 yiwen101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichDom2185 RichDom2185 merged commit 6e6e4f7 into master Aug 11, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the llm-improvements branch August 11, 2024 09:04
@RichDom2185
Copy link
Member Author

Corresponding BE PR: source-academy/backend#1144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants