Skip to content

Implement participant indicator for sessions #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 30, 2024

Conversation

izruff
Copy link
Contributor

@izruff izruff commented Apr 19, 2024

Description

Adds cursor display for other users in the same session and fixed related bugs.
This PR is associated with source-academy/sharedb-ace-backend#26 and source-academy/sharedb-ace#26

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Multiple users join the same session. Upon entering, cursors of other users should automatically show. Each cursor whenever updated will move to its new position and show a label containing the name of the user associated with it ("undefined" if no name is detected).

To test the sharedb-ace package locally, run yarn build then yarn link on the sharedb-ace repository, then run yarn link @sourceacademy/sharedb-ace on the frontend repository.

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-requested a review April 19, 2024 10:27
@RichDom2185 RichDom2185 force-pushed the feat/participant-indicator branch from 49b34ca to b737786 Compare April 19, 2024 10:34
@coveralls
Copy link

coveralls commented Apr 19, 2024

Pull Request Test Coverage Report for Build 9732671463

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 31.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/editor/UseShareAce.tsx 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
src/commons/editor/UseShareAce.tsx 1 22.64%
Totals Coverage Status
Change from base Build 9663643298: 0.006%
Covered Lines: 4894
Relevant Lines: 14653

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Prof @martin-henz, we'll need to bump @sourceacademy/sharedb-ace on NPM and bump it in the frontend before this PR becomes functional.

@RichDom2185 RichDom2185 enabled auto-merge (squash) June 30, 2024 14:20
@RichDom2185 RichDom2185 merged commit 1dbe34e into master Jun 30, 2024
8 checks passed
@RichDom2185 RichDom2185 deleted the feat/participant-indicator branch June 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants