Skip to content

fix(deps): Bump React Ace to v12, fix broken syntax highlighting #2905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 29, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Apr 7, 2024

Description

Supersedes #2880.

Also did a bit of cleanup.

Our custom syntax highlighting is still broken at the moment but other syntax highlighting works. (Fixed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Apr 7, 2024
@coveralls
Copy link

coveralls commented Apr 7, 2024

Pull Request Test Coverage Report for Build 11561349850

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 31.342%

Files with Coverage Reduction New Missed Lines %
src/commons/editor/Editor.tsx 3 39.26%
src/pages/playground/Playground.tsx 3 55.42%
src/commons/editor/UseHighlighting.tsx 14 19.61%
Totals Coverage Status
Change from base Build 11560362906: -0.1%
Covered Lines: 4835
Relevant Lines: 14551

💛 - Coveralls

@RichDom2185 RichDom2185 changed the title Bump React Ace to v11 Bump React Ace to v12 Aug 17, 2024
@RichDom2185 RichDom2185 changed the title Bump React Ace to v12 fix(deps): Bump React Ace to v12, broken syntax highlighting Oct 28, 2024
@RichDom2185 RichDom2185 marked this pull request as ready for review October 28, 2024 19:36
@RichDom2185 RichDom2185 changed the title fix(deps): Bump React Ace to v12, broken syntax highlighting fix(deps): Bump React Ace to v12, fix broken syntax highlighting Oct 28, 2024
@RichDom2185 RichDom2185 enabled auto-merge (squash) October 28, 2024 19:37
@GabrielCWT GabrielCWT self-requested a review October 29, 2024 01:22
@RichDom2185 RichDom2185 merged commit bde6efd into master Oct 29, 2024
9 checks passed
@RichDom2185 RichDom2185 deleted the bump-deps-react-ace branch October 29, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants