Skip to content

Re-enable Z3 4.5.0 for better interpolation #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Re-enable Z3 4.5.0 for better interpolation #536

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8874ec9
Added z3legacy implementation
leventeBajczi Oct 16, 2025
01de644
Formatted new code
leventeBajczi Oct 17, 2025
afb0445
Re-added mistakenly removed deprecation annotation
leventeBajczi Oct 17, 2025
38569fa
suppressed warnings
leventeBajczi Oct 17, 2025
314229e
2024->2025
leventeBajczi Nov 1, 2025
5c634fa
Z3_4_5_0 in enum
leventeBajczi Nov 1, 2025
a753732
nullable -> optional
leventeBajczi Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/org/sosy_lab/java_smt/SolverContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.sosy_lab.java_smt.solvers.smtinterpol.SmtInterpolSolverContext;
import org.sosy_lab.java_smt.solvers.yices2.Yices2SolverContext;
import org.sosy_lab.java_smt.solvers.z3.Z3SolverContext;
import org.sosy_lab.java_smt.solvers.z3legacy.Z3LegacySolverContext;

/**
* Factory class for loading and generating solver contexts. Generates a {@link SolverContext}
Expand All @@ -55,6 +56,7 @@ public enum Solvers {
MATHSAT5,
SMTINTERPOL,
Z3,
Z3LEGACY,
Copy link
Contributor

@baierd baierd Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kfriedberger @PhilippWendler @leventeBajczi i kinda feel like Z3 legacy is a little unspecific. Since the version is fixed, should we use the actual version? I.e. Z3-3.5?

Copy link
Member

@kfriedberger kfriedberger Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solver is able to provide its version string anyway. As it is a version of Z3 with interpolation support, we might name it Z3_INTERPOLATION or simply Z3_3_5 . Special chars like dots or hyphens are not allowed in Java enums.

The JavaSMT enum it independent of the native library, so the library can be called z3Legacy or similar.

Copy link
Contributor Author

@leventeBajczi leventeBajczi Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like encoding the version (Z3_INTERPOLATION could I think be confused with iZ3), so I changed it to Z3_4_5_0.

PRINCESS,
BOOLECTOR,
CVC4,
Expand Down Expand Up @@ -290,6 +292,17 @@ private SolverContext generateContext0(Solvers solverToCreate)
nonLinearArithmetic,
loader);

case Z3LEGACY:
return Z3LegacySolverContext.create(
logger,
config,
shutdownNotifier,
logfile,
randomSeed,
floatingPointRoundingMode,
nonLinearArithmetic,
loader);

case PRINCESS:
return PrincessSolverContext.create(
config, shutdownNotifier, logfile, (int) randomSeed, nonLinearArithmetic);
Expand Down
Loading