ssh: add trust checks before sourcing env vars #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belak
reviewed
Jul 28, 2017
modules/ssh/init.zsh
Outdated
|
|
||
| # Due to the predictability of the env file, check the env file exists and is | ||
| # owned by current EUID before trusting it. | ||
| if [ -f "$_ssh_agent_env" -a ! -O "$_ssh_agent_env" ]; then |
There was a problem hiding this comment.
Please use [[ rather than [
slarew
force-pushed
the
sgl/sshsourceenv
branch
from
0d8d91b to
66bdc9c
Compare
jeffwidman
approved these changes
Aug 29, 2017
There was a problem hiding this comment.
Looks good to me.
Note that #1394 should be resolved first, as this PR is based off of that PR.
slarew
force-pushed
the
sgl/sshsourceenv
branch
from
66bdc9c to
3cf374f
Compare
* Remove persistent SSH auth socket. * Make ps|grep more robust and POSIX compliant. * On macOS, use `-A` switch to "add identities to the agent using any passphrase stored in the user's keychain."
If the user defines identities in `:prezto:module:ssh:load`, always try to load them, even on macOS. On macOS, also try to load Keychain managed identities. (Assume if a user adds an identity to Keychain then the use would want those identities automatically loaded.)
slarew
force-pushed
the
sgl/sshsourceenv
branch
from
3cf374f to
84ad1f3
Compare
|
Since commit ff91c8d unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes