Skip to content

CPP-5239 Migrate to compilation database output format #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 30, 2024

Conversation

friedbyalice
Copy link
Contributor

No description provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would try to include information for both versions of SQ (before 10.6 and after 10.6) here to avoid confusion. WDYT?

I can review the changes in this repo, before we apply them to all other repositories.

@friedbyalice
Copy link
Contributor Author

friedbyalice commented May 6, 2024

I would try to include information for both versions of SQ (before 10.6 and after 10.6) here to avoid confusion. WDYT?

I can review the changes in this repo, before we apply them to all other repositories.

I have tried to mention in the README now, but when going to the other repositories we won't be able to put it in the code of the action itself, unless you want to add commented out code that uses the deprecated property

So the README and the pipeline/action will have an inconsistency

@michael-jabbour-sonarsource
Copy link

michael-jabbour-sonarsource commented May 6, 2024

unless you want to add commented out code that uses the deprecated property

In all the projects, the README file references the script for more details, so I would go for adding comments in the script. Do you have concerns against that?

So the README and the pipeline/action will have an inconsistency

What do you mean? We don't have means to test against older SQ than next, so I am fine with a commented line that is not tested in the pipeline (unless you have a better solution in mind).

@michael-jabbour-sonarsource

Also, we may want to resolve the conflicts...

Co-authored-by: Michael Jabbour michael.jabbour@sonarsource.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Make sure to resolve the conflict so that we can merge when SQ 10.6 is released...

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@michael-jabbour-sonarsource michael-jabbour-sonarsource marked this pull request as ready for review June 30, 2024 14:08
@michael-jabbour-sonarsource michael-jabbour-sonarsource merged commit 66095b3 into main Jun 30, 2024
1 check passed
@michael-jabbour-sonarsource michael-jabbour-sonarsource deleted the bwGeneratesCompdb branch June 30, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants