-
Notifications
You must be signed in to change notification settings - Fork 5
CPP-5239 Migrate to compilation database output format #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to include information for both versions of SQ (before 10.6 and after 10.6) here to avoid confusion. WDYT?
I can review the changes in this repo, before we apply them to all other repositories.
I have tried to mention in the README now, but when going to the other repositories we won't be able to put it in the code of the action itself, unless you want to add commented out code that uses the deprecated property So the README and the pipeline/action will have an inconsistency |
In all the projects, the README file references the script for more details, so I would go for adding comments in the script. Do you have concerns against that?
What do you mean? We don't have means to test against older SQ than next, so I am fine with a commented line that is not tested in the pipeline (unless you have a better solution in mind). |
Also, we may want to resolve the conflicts... |
cbd675e
to
b8174df
Compare
Co-authored-by: Michael Jabbour michael.jabbour@sonarsource.com
e0b77b8
to
44f2522
Compare
ec7b36f
to
929b032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Make sure to resolve the conflict so that we can merge when SQ 10.6 is released...
|
No description provided.