This repository was archived by the owner on Sep 12, 2019. It is now read-only.
Fix Deprecation Warning #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great @bekicot, thank you! |
|
@bekicot looks like there's some failing tests here but I don't think they're related to this PR. Looks like commits on master https://github.com/solidusio/solidus_avatax/commits/master have resulted in failures recently too. |
|
@djones Noticed too, not sure what caused the problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alias_method_chainis going to be deprecated.This fix convert the decorators into a module and prepend it to the class
cc #27 @djones