This repository was archived by the owner on Sep 12, 2019. It is now read-only.
Updates for Solidus >=1.3 #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solidus 1.3 introduced persisted shipping rate taxes. This updates the shipping_rate spec to reflect the changes made in Solidus 1.3. Also makes sure that this extension not installs for Solidus v2.1, as it is not compatible to Solidus 2.1 yet.
Rake 2.0 and Rails 5 need at least Ruby 2.2.2
mamhoff
approved these changes
Jan 11, 2017
|
Ok, so the test run indicates a flaky spec where the order of an array matters more than it should. |
Senjai
approved these changes
Jan 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidus 1.3 introduced persisted shipping rate taxes. This updates the shipping_rate spec to reflect the changes made in Solidus 1.3.
Also makes sure that this extension only installs for 1.x series of Solidus, as it is not compatible to Solidus 2.x yet.