update Modifying values in arrays / Appending new values simplify. #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current ```Appending new values To append a new element to an array within a store, you specify the target array and set the index to the desired position. For example, if you wanted to append the new element to the end of the array, you would set the index to array.length: ``` this phrasing may be a little ambiguous, the example for appending, using the path syntax, will always use the array.length to append a value. > and set the index to the desired position may imply to readers that read this section without prior context that the index can be used as insertion point in the array. not realizing that only works with non existing index such as the length, or higher index
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current
this phrasing may be a little ambiguous, the example for appending, using the path syntax, will always use the array.length to append a value.
may imply to readers that read this section without prior context that the index can be used as insertion point in the array. not realizing that only works with non existing index such as the length, or higher index
Description(required)
proposing or revised explanation, that focuses on the usage of array.length as an alternative
"shortcut" to using a setter function and a spread for a "appending of a single value"
feedback from discord
Related issues & labels
Stores
https://docs.solidjs.com/concepts/stores#appending-new-values