Skip to content

Improve awkward styling and sentences in classList.mdx #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marvin-j97
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description

Improves styling in classList.mdx, by making backtick styling consistent for "class" and "classList".

Also fixes a sentence's paranthesis and its period.

improve styling and fix some sentences
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit b7db21a
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b91595c00200081299fc

1 similar comment
Copy link

netlify bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit b7db21a
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b91595c00200081299fc

Copy link

netlify bot commented May 23, 2025

Deploy Preview for solid-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 74cb41e
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6830b9396ee5170008ea476f

Copy link

netlify bot commented May 23, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 504452d
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6834f69e029d9b0008cc4f22
😎 Deploy Preview https://deploy-preview-1185--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes
Copy link
Member

Hi @marvin-j97 ! Thank you for putting this PR in.

Before I get to reviewing this, do you mind fixing it so the deploy preview works? The error I'm currently seeing on our Netlify logs is this:

git ref pull/1185/head does not exist or you do not have permission

@marvin-j97
Copy link
Contributor Author

Hi @marvin-j97 ! Thank you for putting this PR in.

Before I get to reviewing this, do you mind fixing it so the deploy preview works? The error I'm currently seeing on our Netlify logs is this:

git ref pull/1185/head does not exist or you do not have permission

Not sure what that means - that is a Netlify error... forks are always public anyway.

@LadyBluenotes
Copy link
Member

We need the deploy preview to work to make sure the build doesn't break. Could you either fix this PR, please, or re-submit the changes in a new PR one so it works?

@marvin-j97
Copy link
Contributor Author

marvin-j97 commented May 27, 2025

We need the deploy preview to work to make sure the build doesn't break. Could you either fix this PR, please, or re-submit the changes in a new PR one so it works?

There's nothing I did though that should prevent pulling the PR on Netlify's side... I just changed a markdown page.

Edit: I just noticed it built fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants