Skip to content

Disable Twoslash for now #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

amirhhashemi
Copy link
Collaborator

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

#1140 is related to a bug I discovered a few days ago, which has not been fixed yet. I think it would be best to remove Twoslash for now, as it does not seem to be very stable. We can reintroduce it once it's more stable.

Related issues & labels

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 7ef1ecd
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67e5ba9e59124300088f9c0b
😎 Deploy Preview https://deploy-preview-1145--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) March 27, 2025 20:52
@LadyBluenotes LadyBluenotes merged commit 26e79a8 into solidjs:main Mar 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]:
2 participants