p-token: Fix error codes #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
reviewed
Apr 21, 2025
There was a problem hiding this comment.
Good looks, but I think we have a deeper problem when it comes to mismatching. As I mentioned in a few comments, since P-Token is storing primitives and using fallible on-demand deserialization, it will probably fail on different invalid account states than when SPL-Token would.
For example, if a malformed Mint gets passed to SPL-Token, it's going to throw at Mint::unpack for a whole range of invalid fields. On P-Token, some invalid state fields may not be caught until they are queried.
Some of these things may not be realistic test scenarios, and we can consider that fact, but it's going to make it hard to differentially fuzz these programs if we're too divergent in that respect.
febo
force-pushed
the
febo/fix-error-codes
branch
from
eadc3ae to
e3eee9e
Compare
febo
force-pushed
the
febo/fix-error-codes
branch
from
eb26717 to
df7e7c3
Compare
joncinque
reviewed
May 1, 2025
buffalojoec
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fuzzing p-token has revealed mismatches in the error codes returned by p-token compared to spl-token implementation.
Solution
Fix the mismatches. In some cases, extra validation on the account data was needed to replicate the same error code.