CI: Fix semver checks on publish #44
Conversation
#### Problem The semver checks step during publish is broken because it's simply passing in the folder, but there's some additional work needed to decompose it into a manifest path. #### Summary of changes Similar to many other repos, add a semver script which will pull out the manifest given a path.
.github/workflows/publish-rust.yml
Outdated
| @@ -68,7 +68,7 @@ jobs: | |||
| run: pnpm zx ./scripts/rust/test.mjs "${{ inputs.package_path }}" | |||
|
|
|||
| - name: Check semver | |||
| run: pnpm rust:semver ${{ inputs.package_path }} --release-type ${{ inputs.level }} | |||
| run: pnpm rust:semver --manifest-path "${{ inputs.package_path }}/Cargo.toml" --release-type ${{ inputs.level }} | |||
There was a problem hiding this comment.
This will work for crates > 0.x. Not sure if you would like to update the script with the latest "fix": https://github.com/anza-xyz/pinocchio/blob/main/.github/workflows/publish.yml#L52-L81
There was a problem hiding this comment.
Looks great. Last tiny bit that I forgot to mention on my previous comment. You can bring back the level/version input options as well: https://github.com/anza-xyz/pinocchio/blob/main/.github/workflows/publish.yml#L19-L36
Then you will also need to check for the level and version values: https://github.com/anza-xyz/pinocchio/blob/main/.github/workflows/publish.yml#L129-L133
|
Can we just do that in a separate PR? I don't see the value in it, and it's unrelated to this PR |
|
Oh I see, it's in all the others, ah ok. I'll do it in all of them |
|
Ok, should be good for another look |
Better option than #43
Problem
The semver checks step during publish is broken because it's simply passing in the folder, but there's some additional work needed to decompose it into a manifest path.
Summary of changes
Make the manifest path correctly