Skip to content

p-token: Add format and lint scripts #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2025
Merged

p-token: Add format and lint scripts #40

merged 4 commits into from
Mar 14, 2025

Conversation

febo
Copy link
Contributor

@febo febo commented Mar 13, 2025

Problem

Currently, both the interface and p-token are not being checked for lint issues on the CI.

Solution

Add interface and p-token lint jobs to the CI. This included:

  • Fixing current format issues
  • Fixing clippy warnings
  • Adding the scripts to package.json
  • Updating the main workflow

@febo febo marked this pull request as ready for review March 13, 2025 16:04
@febo febo requested a review from joncinque March 13, 2025 16:04
joncinque
joncinque approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little bit, looks great otherwise!

@febo
Copy link
Contributor Author

febo commented Mar 13, 2025

The second run failed since the fixtures directory already exists. I will relax that requirement on the other PR so this would not be a problem.

@febo febo force-pushed the febo/p-token-lint branch from 6bf4b9d to a6335e6 Compare March 14, 2025 16:07
Base automatically changed from febo/fixtures to main March 14, 2025 16:37
@febo febo force-pushed the febo/p-token-lint branch from a6335e6 to 028fbdd Compare March 14, 2025 16:41
@febo febo merged commit 261bbdd into main Mar 14, 2025
15 checks passed
@febo febo deleted the febo/p-token-lint branch March 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque joncinque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febo @joncinque